fix: Credentials are checked when user login #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qgau
approved these changes
Apr 2, 2024
slim0
approved these changes
Apr 2, 2024
nitreb
force-pushed
the
add-status-check-on-login
branch
from
d582037 to
b9fac06
Compare
nitreb
commented
Apr 2, 2024
Comment on lines
-1885
to
-1914
| def test_subset_is_using_dims_instead_of_coord(self, tmp_path): | ||
| command = [ | ||
| "copernicusmarine", | ||
| "subset", | ||
| "--dataset-id", | ||
| "dataset-topaz6-arc-15min-3km-be", | ||
| "--variable", | ||
| "zos", | ||
| "--start-datetime", | ||
| "2018-01-01T00:00:00", | ||
| "--end-datetime", | ||
| "2018-01-01T03:59:59", | ||
| "--minimum-longitude", | ||
| "0", | ||
| "--maximum-longitude", | ||
| "1", | ||
| "--minimum-latitude", | ||
| "0", | ||
| "--maximum-latitude", | ||
| "1", | ||
| "--force-download", | ||
| "-o", | ||
| f"{tmp_path}", | ||
| "-f", | ||
| "result.nc", | ||
| ] | ||
|
|
||
| output = subprocess.run(command) | ||
| assert output.returncode == 0 | ||
|
|
There was a problem hiding this comment.
This test fails and I don't understand what it does so ciao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.